Skip to content

Remove experimental status from String component #13098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 12, 2020
Merged

Remove experimental status from String component #13098

merged 1 commit into from
Feb 12, 2020

Conversation

@savvasal
Copy link
Contributor

@savvasal savvasal commented Feb 10, 2020

@javiereguiluz
Copy link
Member

javiereguiluz commented Feb 11, 2020

@savvasal thanks for this contribution! However, I think that the change should be to remove this versionadded directive entirely ... because in 5.1, the component is neither new nor experimental, so no extra info is needed.

@javiereguiluz javiereguiluz added this to the 5.1 milestone Feb 11, 2020
@javiereguiluz javiereguiluz force-pushed the remove-experimental-status-from-string branch from 0fe28f2 to c86a35d Compare February 12, 2020 19:35
@javiereguiluz
Copy link
Member

javiereguiluz commented Feb 12, 2020

Thank you @savvasal.

@javiereguiluz javiereguiluz merged commit c86a35d into symfony:master Feb 12, 2020
@savvasal savvasal deleted the remove-experimental-status-from-string branch February 12, 2020 22:18
@javiereguiluz javiereguiluz mentioned this pull request Feb 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@OskarStark OskarStark OskarStark approved these changes

Assignees

No one assigned

Labels

Status: Reviewed String

Projects

None yet

Milestone

5.1

Development

Successfully merging this pull request may close these issues.

4 participants

@savvasal @javiereguiluz @OskarStark @carsonbot