Skip to content

Editorial: replace [[UnderlyingIterator]] with [[UnderlyingIterators]] #3712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+35 −17
Open

Editorial: replace [[UnderlyingIterator]] with [[UnderlyingIterators]] #3712

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1d2f604
Editorial: replace [[UnderlyingIterator]] with [[UnderlyingIterators]]
michaelficarra Nov 3, 2025
74292e9
try to address ecmarkup lint error
michaelficarra Nov 3, 2025
eb5208b
bump ecmarkup to 21.5.0
michaelficarra Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"license": "SEE LICENSE IN https://tc39.es/ecma262/#sec-copyright-and-software-license",
"homepage": "https://tc39.es/ecma262/",
"devDependencies": {
"ecmarkup": "^21.4.0",
"ecmarkup": "^21.5.0",
"jsdom": "^27.0.0"
}
}
42 changes: 30 additions & 12 deletions spec.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7192,6 +7192,24 @@
</emu-alg>
</emu-clause>

<emu-clause id="sec-iteratorcloseall" type="abstract operation">
<h1>
IteratorCloseAll (
_iters_: a List of Iterator Records,

Check warning on line 7198 in spec.html

View workflow job for this annotation

GitHub Actions / check for newly-introduced spelling errors

Potential Typo 

"iters" is not a previously used word or composed of previously used words. Perhaps it is a typo?
_completion_: a Completion Record,
): a Completion Record
</h1>
<dl class="header">
<dt>skip global checks</dt>
<dd>true</dd>
</dl>
<emu-alg>
1. For each element _iter_ of _iters_, in reverse List order, do

Check warning on line 7207 in spec.html

View workflow job for this annotation

GitHub Actions / check for newly-introduced spelling errors

Potential Typo 

"iters" is not a previously used word or composed of previously used words. Perhaps it is a typo?
1. Set _completion_ to Completion(IteratorClose(_iter_, _completion_)).
1. Return ? _completion_.
</emu-alg>
</emu-clause>

<emu-clause id="sec-ifabruptcloseiterator" aoid="IfAbruptCloseIterator">
<h1>IfAbruptCloseIterator ( _value_, _iteratorRecord_ )</h1>
<p>IfAbruptCloseIterator is a shorthand for a sequence of algorithm steps that use an Iterator Record. An algorithm step of the form:</p>
Expand Down Expand Up @@ -47989,12 +48007,12 @@
<h1>%IteratorHelperPrototype%.return ( )</h1>
<emu-alg>
1. Let _O_ be *this* value.
1. Perform ? RequireInternalSlot(_O_, [[UnderlyingIterator]]).
1. Perform ? RequireInternalSlot(_O_, [[UnderlyingIterators]]).
1. Assert: _O_ has a [[GeneratorState]] internal slot.
1. If _O_.[[GeneratorState]] is ~suspended-start~, then
1. Set _O_.[[GeneratorState]] to ~completed~.
1. NOTE: Once a generator enters the completed state it never leaves it and its associated execution context is never resumed. Any execution state associated with _O_ can be discarded at this point.
1. Perform ? IteratorClose(_O_.[[UnderlyingIterator]], NormalCompletion(~unused~)).
1. Perform ? IteratorCloseAll(_O_.[[UnderlyingIterators]], NormalCompletion(~unused~)).
1. Return CreateIteratorResultObject(*undefined*, *true*).
1. Let _C_ be ReturnCompletion(*undefined*).
1. Return ? GeneratorResumeAbrupt(_O_, _C_, *"Iterator Helper"*).
Expand Down Expand Up @@ -48161,8 +48179,8 @@
1. If _value_ is ~done~, return ReturnCompletion(*undefined*).
1. Let _completion_ be Completion(Yield(_value_)).
1. IfAbruptCloseIterator(_completion_, _iterated_).
1. Let _result_ be CreateIteratorFromClosure(_closure_, *"Iterator Helper"*, %IteratorHelperPrototype%, « [[UnderlyingIterator]] »).
1. Set _result_.[[UnderlyingIterator]] to _iterated_.
1. Let _result_ be CreateIteratorFromClosure(_closure_, *"Iterator Helper"*, %IteratorHelperPrototype%, « [[UnderlyingIterators]] »).
1. Set _result_.[[UnderlyingIterators]] to « _iterated_ ».
1. Return _result_.
</emu-alg>
</emu-clause>
Expand Down Expand Up @@ -48211,8 +48229,8 @@
1. Let _completion_ be Completion(Yield(_value_)).
1. IfAbruptCloseIterator(_completion_, _iterated_).
1. Set _counter_ to _counter_ + 1.
1. Let _result_ be CreateIteratorFromClosure(_closure_, *"Iterator Helper"*, %IteratorHelperPrototype%, « [[UnderlyingIterator]] »).
1. Set _result_.[[UnderlyingIterator]] to _iterated_.
1. Let _result_ be CreateIteratorFromClosure(_closure_, *"Iterator Helper"*, %IteratorHelperPrototype%, « [[UnderlyingIterators]] »).
1. Set _result_.[[UnderlyingIterators]] to « _iterated_ ».
1. Return _result_.
</emu-alg>
</emu-clause>
Expand Down Expand Up @@ -48272,8 +48290,8 @@
1. IfAbruptCloseIterator(_backupCompletion_, _iterated_).
1. Return ? IteratorClose(_iterated_, _completion_).
1. Set _counter_ to _counter_ + 1.
1. Let _result_ be CreateIteratorFromClosure(_closure_, *"Iterator Helper"*, %IteratorHelperPrototype%, « [[UnderlyingIterator]] »).
1. Set _result_.[[UnderlyingIterator]] to _iterated_.
1. Let _result_ be CreateIteratorFromClosure(_closure_, *"Iterator Helper"*, %IteratorHelperPrototype%, « [[UnderlyingIterators]] »).
1. Set _result_.[[UnderlyingIterators]] to « _iterated_ ».
1. Return _result_.
</emu-alg>
</emu-clause>
Expand Down Expand Up @@ -48320,8 +48338,8 @@
1. Let _completion_ be Completion(Yield(_mapped_)).
1. IfAbruptCloseIterator(_completion_, _iterated_).
1. Set _counter_ to _counter_ + 1.
1. Let _result_ be CreateIteratorFromClosure(_closure_, *"Iterator Helper"*, %IteratorHelperPrototype%, « [[UnderlyingIterator]] »).
1. Set _result_.[[UnderlyingIterator]] to _iterated_.
1. Let _result_ be CreateIteratorFromClosure(_closure_, *"Iterator Helper"*, %IteratorHelperPrototype%, « [[UnderlyingIterators]] »).
1. Set _result_.[[UnderlyingIterators]] to « _iterated_ ».
1. Return _result_.
</emu-alg>
</emu-clause>
Expand Down Expand Up @@ -48404,8 +48422,8 @@
1. If _value_ is ~done~, return ReturnCompletion(*undefined*).
1. Let _completion_ be Completion(Yield(_value_)).
1. IfAbruptCloseIterator(_completion_, _iterated_).
1. Let _result_ be CreateIteratorFromClosure(_closure_, *"Iterator Helper"*, %IteratorHelperPrototype%, « [[UnderlyingIterator]] »).
1. Set _result_.[[UnderlyingIterator]] to _iterated_.
1. Let _result_ be CreateIteratorFromClosure(_closure_, *"Iterator Helper"*, %IteratorHelperPrototype%, « [[UnderlyingIterators]] »).
1. Set _result_.[[UnderlyingIterators]] to « _iterated_ ».
1. Return _result_.
</emu-alg>
</emu-clause>
Expand Down
Loading