Skip to content

Conversation

@gibson042
Copy link
Member

@michaelficarra
Copy link
Member

Let's hold off on this until we get approval on the strategy for #552.

@gibson042
Copy link
Member Author

Why? Assuming static positioning for so many elements is unnecessarily brittle.

@michaelficarra
Copy link
Member

I just don't want to introduce the complexity until it buys us something.

@gibson042 gibson042 force-pushed the 2023-09-absolute-offset branch from 0233e00 to e32683e Compare September 2, 2023 17:28
@gibson042
Copy link
Member Author

Well, I'd like to adopt #552 with a local stylesheet but doing so breaks the toolbox positioning without something like this. I can address that locally as well, but the code here is strictly a generalization—when el.offsetParent itself has no offsetParent (as is the case for relevant elements with the current stylesheet), then getAbsoluteOffset(el, 'offsetTop') is equivalent to the el.offsetTop that it's replacing, and likewise for offsetLeft. It only has an effect when that assumption doesn't hold, in which case the effect is to fix what would otherwise be a bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants