Added test for Islamic calendar fallbacks [intl-era-monthcode] #4627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e: Intl.Era-monthcode
ptomato
requested changes
Oct 31, 2025
test/intl402/DateTimeFormat/constructor-options-calendar-islamic-fallback.js
Outdated
Show resolved
Hide resolved
test/intl402/DateTimeFormat/constructor-options-calendar-islamic-fallback.js
Outdated
Show resolved
Hide resolved
…ic-fallback.js Co-authored-by: Philip Chimento <philip.chimento@gmail.com>
…ic-fallback.js Co-authored-by: Philip Chimento <philip.chimento@gmail.com>
ptomato
requested changes
Nov 1, 2025
| "dangi", | ||
| "ethioaa", | ||
| "ethiopic", | ||
| "ethiopic-amete-alem", |
There was a problem hiding this comment.
Suggested change
| "ethiopic-amete-alem", |
Sorry I didn't notice this in the earlier review. I realized that the CanonicalizeUValue in step 9.b means no aliases allowed here.
test/intl402/DateTimeFormat/constructor-options-calendar-islamic-fallback.js
Outdated
Show resolved
Hide resolved
…ic-fallback.js Co-authored-by: Philip Chimento <philip.chimento@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Era Monthcode spec indicates that the fallback when "islamic" or "islamic-rgsa" calendars used must be "an implementation- and locale-defined calendar type that is one of the values returned from AvailableCalendars."
this PR replaces #4612