Skip to content

Removing alt from header logo to compliment challenge. #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Removing alt from header logo to compliment challenge. #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
179867d
Removing alt from header logo to compliment challenge.
thezacharytaylor Dec 23, 2022
a6bdcd1
Removing checka11y from homepage test
thezacharytaylor Dec 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/header.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ const Header = ({inert}) => {
<div id="header-logo">
<a href="/" className="header-main-item">
<span className="logo-img">
<img src={CampSpotsLogo} alt=""/>
<img src={CampSpotsLogo} />
</span>
<span className="logo-text">CampSpots</span>
</a>
Expand Down
8 changes: 1 addition & 7 deletions exercise3-cypress-integration/HomePage.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,4 @@ describe('HomePage', () => {
it('should have a Header', () => {
cy.get('#header').contains('CampSpots')
})

it('should have no accessibility violations', () => {
cy.checkA11y({
exclude: ['div#portal-root']
})
})
})
})