-
Notifications
You must be signed in to change notification settings - Fork 615
Version Packages #8375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version Packages #8375
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
WalkthroughThis PR releases version 5.111.8 of the thirdweb package with Epic Games Authentication support, bumps dependent packages (nebula and wagmi-adapter), updates their changelogs, and removes the corresponding changeset file. All changes are version updates and documentation records. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
packages/thirdweb/CHANGELOG.md (2)
3-8: Verify semver: “Epic Games Authentication” may warrant a Minor bump, not Patch.Adding a new auth provider usually expands public API (new strategy/option), which our rules classify as a minor version. Prior “Adds Steam auth” was released under Minor Changes. Please confirm if this should be 5.112.0 (Minor) rather than 5.111.8 (Patch), or clarify why it’s patch-only. As per coding guidelines.
7-7: Optional: add a brief usage note/link for the new provider.A one-liner or docs link (e.g., how to enable/use Epic auth in in-app/ecosystem wallets) improves DX for readers scanning the changelog.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (9)
.changeset/beige-candles-happen.md(0 hunks)apps/wagmi-demo/CHANGELOG.md(1 hunks)apps/wagmi-demo/package.json(1 hunks)packages/nebula/CHANGELOG.md(1 hunks)packages/nebula/package.json(1 hunks)packages/thirdweb/CHANGELOG.md(1 hunks)packages/thirdweb/package.json(1 hunks)packages/wagmi-adapter/CHANGELOG.md(1 hunks)packages/wagmi-adapter/package.json(1 hunks)
💤 Files with no reviewable changes (1)
- .changeset/beige-candles-happen.md
🧰 Additional context used
📓 Path-based instructions (2)
packages/wagmi-adapter/**
📄 CodeRabbit inference engine (CLAUDE.md)
Wagmi ecosystem integration is in
packages/wagmi-adapter/
Files:
packages/wagmi-adapter/CHANGELOG.mdpackages/wagmi-adapter/package.json
**/package.json
📄 CodeRabbit inference engine (AGENTS.md)
Track bundle budgets via
package.json#size-limit
Files:
packages/nebula/package.jsonpackages/wagmi-adapter/package.jsonpackages/thirdweb/package.jsonapps/wagmi-demo/package.json
🧠 Learnings (6)
📓 Common learnings
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-08-29T15:37:38.513Z
Learning: Applies to .changeset/*.md : Each change in `packages/*` must include a changeset for the appropriate package
📚 Learning: 2025-07-18T19:19:55.613Z
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/wagmi-adapter/** : Wagmi ecosystem integration is in `packages/wagmi-adapter/`
Applied to files:
packages/wagmi-adapter/CHANGELOG.mdpackages/wagmi-adapter/package.jsonapps/wagmi-demo/CHANGELOG.mdapps/wagmi-demo/package.json
📚 Learning: 2025-08-29T15:37:38.513Z
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-08-29T15:37:38.513Z
Learning: Applies to packages/thirdweb/exports/** : Export all public API via `packages/thirdweb/exports/`, grouped by feature
Applied to files:
packages/nebula/package.jsonpackages/wagmi-adapter/package.jsonpackages/thirdweb/package.json
📚 Learning: 2025-07-18T19:19:55.613Z
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/exports/** : Export everything via `exports/` directory, grouped by feature in the SDK public API
Applied to files:
packages/nebula/package.jsonpackages/wagmi-adapter/package.jsonpackages/thirdweb/package.json
📚 Learning: 2025-08-29T15:37:38.513Z
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-08-29T15:37:38.513Z
Learning: Applies to .changeset/*.md : Version bump rules: patch for non‑API changes; minor for new/modified public API
Applied to files:
packages/nebula/CHANGELOG.mdapps/wagmi-demo/CHANGELOG.mdpackages/thirdweb/CHANGELOG.md
📚 Learning: 2025-07-18T19:19:55.613Z
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Surface breaking changes prominently in PR descriptions
Applied to files:
packages/thirdweb/CHANGELOG.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: Size
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: Unit Tests
- GitHub Check: Lint Packages
- GitHub Check: Build Packages
- GitHub Check: Socket Security: Pull Request Alerts
- GitHub Check: Analyze (javascript)
🔇 Additional comments (8)
packages/nebula/package.json (1)
60-60: Version bump is correct and consistent.Patch version increment aligns with the dependency update to thirdweb@5.111.8, consistent with the corresponding CHANGELOG entry.
packages/wagmi-adapter/CHANGELOG.md (1)
3-4: Verify CHANGELOG entry for 0.2.183 is complete.The new version 0.2.183 entry (lines 3–4) has no "Patch Changes" section, unlike all other entries in this file (e.g., 0.2.182 below). While the PR description notes "No patch details listed," this may indicate either intentional omission or incomplete automation. Verify that this entry is not missing dependency updates or other release notes that should be documented.
apps/wagmi-demo/CHANGELOG.md (1)
3-9: CHANGELOG entry is well-formed.The 0.0.28 release entry is properly structured with dependency updates to thirdweb@5.111.8 and @thirdweb-dev/wagmi-adapter@0.2.183. Patch version bump is appropriate.
packages/thirdweb/package.json (1)
433-433: Version bump is correct.Patch version increment to 5.111.8 reflects the non-API addition of Epic Games Authentication, with no dependency changes needed.
packages/nebula/CHANGELOG.md (1)
3-8: CHANGELOG entry is well-formed and consistent.The 0.2.86 release entry follows the expected Changeset format with the dependency update to thirdweb@5.111.8 properly documented. Aligns with the package.json version change.
packages/thirdweb/CHANGELOG.md (1)
3-8: Changelog entry format looks good.Header, links, and credit follow the existing style; no nits.
apps/wagmi-demo/package.json (1)
4-4: Version bump aligns with coordinated release.The version change to 0.0.28 matches the PR objectives and coordinated release of wagmi-inapp. Dependencies correctly use
workspace:*to resolve to the newly released versions.packages/wagmi-adapter/package.json (1)
59-59: Version bump is correct and aligns with coordinated release.The version change to 0.2.183 matches the PR objectives and is part of the coordinated package release. All package configuration (exports, peer dependencies, build scripts) remains consistent.
size-limit report 📦
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8375 +/- ##
=======================================
Coverage 54.64% 54.64%
=======================================
Files 919 919
Lines 60704 60704
Branches 4114 4113 -1
=======================================
Hits 33171 33171
Misses 27431 27431
Partials 102 102
🚀 New features to boost your workflow:
|
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@thirdweb-dev/nebula@0.2.86
Patch Changes
1f440d0]:thirdweb@5.111.8
Patch Changes
1f440d0Thanks @0xFirekeeper! - Added Epic Games Authentication@thirdweb-dev/wagmi-adapter@0.2.183
wagmi-inapp@0.0.28
Patch Changes
1f440d0]:PR-Codex overview
This PR focuses on updating version numbers across multiple packages, along with adding new changelog entries that reflect these updates and dependency changes.
Detailed summary
versioninpackages/thirdweb/package.jsonfrom5.111.7to5.111.8versioninapps/wagmi-demo/package.jsonfrom0.0.27to0.0.28versioninpackages/nebula/package.jsonfrom0.2.85to0.2.86versioninpackages/wagmi-adapter/package.jsonfrom0.2.182to0.2.183CHANGELOG.mdforpackages/nebula,apps/wagmi-demo, andpackages/thirdwebreflecting the updates and new dependencies.Summary by CodeRabbit
New Features
Chores