soc/ite/it8xxx2: make ARCH_IRQ_VECTOR_TABLE_ALIGN constant #98906
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set ARCH_IRQ_VECTOR_TABLE_ALIGN to 4, to keep offset for FWID constant. Bug ID is b:320527549 on google issue tracker. Signed-off-by: Ruibin Chang <Ruibin.Chang@ite.com.tw>
zephyrbot
requested review from
Chenhongren,
Dino-Li,
GTLin08,
fabiobaltieri and
keith-zephyr
|
|
Hi @RuibinChang, thanks a lot for the commit, could you update the message to mention that the vector table changed size since a825e01 and it is causing issues with downstream applications? The whole fwid story make sense only for chromeos so some more generic context would help. The bug number reference can go, it's not public anyway. |
fabiobaltieri
added
the
Trivial
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set ARCH_IRQ_VECTOR_TABLE_ALIGN to 4, to keep offset for FWID constant.
Bug ID is b:320527549 on google issue tracker.