fix: adjustments to german grammar #452
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fipguide ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Hi there! 👋 Thank you for your contribution to the FIP Guide! 🚀 Checklist before merging:
|
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces a German style guide and applies its typography and terminology standards across multiple content files. The changes focus on consistent formatting of currency values, proper terminology (replacing "Rabatt" with "Ermäßigung"), and correcting a spelling error.
- Adds a comprehensive German style guide covering typography, spacing, gender-neutral language, and punctuation
- Standardizes currency formatting with spaces between numbers and currency symbols (e.g.,
10€→10 €) - Replaces "Rabatt" with "Ermäßigung" for consistency in FIP discount terminology
- Corrects spelling error: "Freifahrtsschein" → "Freifahrtschein"
Reviewed Changes
Copilot reviewed 9 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| styleguide_de.md | New German style guide document defining typography, spacing, and language standards |
| content/operator/sncf/index.de.md | Corrects spelling of "Freifahrtschein" |
| content/operator/oebb/index.de.md | Standardizes currency spacing and replaces "Rabatt" with "Ermäßigung" |
| content/operator/gysev/index.de.md | Replaces "Rabatt" with "Ermäßigung" |
| content/operator/eurostar/index.de.md | Standardizes currency spacing and replaces "Rabatt" with "Ermäßigung" |
| content/news/5/index.de.md | Standardizes currency spacing throughout |
| content/country/united-kingdom/index.de.md | Replaces "Rabatt" with "Ermäßigung" and adjusts grammatical agreement |
| content/country/switzerland/index.de.md | Standardizes currency spacing |
| content/country/italy/index.de.md | Standardizes currency spacing |
| content/country/france/index.de.md | Replaces "Rabatt" with "Ermäßigung" (appears twice) |
| content/country/austria/index.de.md | Standardizes currency spacing |
| content/booking/sncf-ticket-office/index.de.md | Replaces "Rabatt" with "Ermäßigung" |
| content/booking/sncf-phone/index.de.md | Replaces "Rabatt" with "Ermäßigung" (multiple instances) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| Grenzüberschreitende Verbindungen aus Großbritannien werden von [Eurostar]({{< ref "/operator/eurostar" >}} "Eurostar") betrieben. Diese verkehren von London durch den Eurotunnel nach Lille und Paris. FIP Globalpreise sind für diese Verbindungen verfügbar. | ||
|
|
||
| Ab Folkestone gibt es auch den LeShuttle Autozug durch den Eurotunnel, bei dem jedoch kein FIP Rabatt gewährt wird. Zusätzlich gibt es verschiedene Fährverbindungen zwischen Frankreich und Großbritannien, bei denen jedoch kein FIP Rabatt gewährt wird. | ||
| Ab Folkestone gibt es auch den LeShuttle Autozug durch den Eurotunnel, bei dem jedoch kein FIP Ermäßigung gewährt wird. Zusätzlich gibt es verschiedene Fährverbindungen zwischen Frankreich und Großbritannien, bei denen jedoch kein FIP Ermäßigung gewährt wird. |
There was a problem hiding this comment.
Grammatical error: 'kein' requires the nominative case, but 'Ermäßigung' is feminine, so it should be 'keine FIP Ermäßigung'. The same error occurs twice in this sentence.
Suggested change
| Ab Folkestone gibt es auch den LeShuttle Autozug durch den Eurotunnel, bei dem jedoch kein FIP Ermäßigung gewährt wird. Zusätzlich gibt es verschiedene Fährverbindungen zwischen Frankreich und Großbritannien, bei denen jedoch kein FIP Ermäßigung gewährt wird. | |
| Ab Folkestone gibt es auch den LeShuttle Autozug durch den Eurotunnel, bei dem jedoch keine FIP Ermäßigung gewährt wird. Zusätzlich gibt es verschiedene Fährverbindungen zwischen Frankreich und Großbritannien, bei denen jedoch keine FIP Ermäßigung gewährt wird. |
therobrob
added
the
content
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recommendations are summarized in the issue #356. I have also made adjustments to the german versions.