Skip to content

Conversation

@cemakd
Copy link
Contributor

@cemakd cemakd commented Oct 31, 2025

This allows node driver to avoid an unnecessary 15 second startup delay when node name flag isn't set.

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #2200

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

This allows csi-node to avoid an unnecessary 15 second startup delay when node name flag isn't set.
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 31, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cemakd
Once this PR has been reviewed and has the lgtm label, please assign msau42 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 31, 2025
@sunnylovestiramisu sunnylovestiramisu self-assigned this Nov 3, 2025
)

func GetNodeWithRetry(ctx context.Context, nodeName string) (*v1.Node, error) {
if nodeName == "" {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this cause log spamming in the issue's case? Because they will not be specifying nodeName, and we will log the error. Can you confirm that the error will only get log once, and will not spam the logging?

@sunnylovestiramisu
Copy link
Contributor

/test pull-gcp-compute-persistent-disk-csi-driver-e2e-arm

@k8s-ci-robot
Copy link
Contributor

@cemakd: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gcp-compute-persistent-disk-csi-driver-e2e-arm bc308be link false /test pull-gcp-compute-persistent-disk-csi-driver-e2e-arm

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Device Cache initialization slowing down csi-node when --node-name isn't specified

3 participants