Skip to content

Return early when node name is empty #2225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −0
Open

Return early when node name is empty #2225

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pkg/k8sclient/node.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package k8sclient

import (
"context"
"fmt"
"time"

v1 "k8s.io/api/core/v1"
Expand All @@ -13,6 +14,9 @@ import (
)

func GetNodeWithRetry(ctx context.Context, nodeName string) (*v1.Node, error) {
if nodeName == "" {
Copy link
Contributor

@sunnylovestiramisu sunnylovestiramisu Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this cause log spamming in the issue's case? Because they will not be specifying nodeName, and we will log the error. Can you confirm that the error will only get log once, and will not spam the logging?

return nil, fmt.Errorf("node name is empty")
}
cfg, err := rest.InClusterConfig()
if err != nil {
return nil, err
Expand Down