Ignore missingType.iterableValue for data-providers

[staabm]

As we are now validating data-providers by its return/yield statements, I think we should no longer throw a

Method DataProviderIterableValueTest\Foo::dataProvider() return type has no value type specified in iterable type iterable.

error onto the PHPStan user

---

requires phpstan/phpstan-src#4488

[ondrejmirtes]

This assumes an implementation detail that missingType.iterableValue is reported by a rule that hooks onto InClassMethodNode.

You can remove this instanceof and just ask for $scope->isInClass(), $scope->getFunction() etc.

[staabm]

got this code from the docs :).

doc-fix in phpstan/phpstan#13726

thank you.

[ondrejmirtes]

BTW I love this, it's genius :)

[ondrejmirtes]

Thank you!

[VincentLanglet]

@staabm @ondrejmirtes Is there an easy way to (?)

• take advantage of the DataProviderDataRule
• without enabling the DataProviderReturnTypeIgnoreExtension

Would it be ok to have such option ?

Maybe like

checkDataProviderData: %featureToggles.bleedingEdge%
ignoreDataProviderReturnType: %featureToggles.bleedingEdge%

PHPStan\Type\PHPUnit\DataProviderReturnTypeIgnoreExtension:
		phpstan.ignoreErrorExtension: %phpunit.ignoreDataProviderReturnType%

or

checkDataProviderData: %featureToggles.bleedingEdge%
checkDataProviderReturnType: false

PHPStan\Type\PHPUnit\DataProviderReturnTypeIgnoreExtension:
		phpstan.ignoreErrorExtension: [%phpunit.ignoreDataProviderReturnType%, not(%phpunit.checkDataProviderReturnType%)]

if such syntax exists...

In our codebase, we appreciate the fact PHPStan enforce the detailed phpdoc of iterable (for documentation purpose), and even if the return/yield statement are now checked, we still find some interest in the required phpdoc.

[ondrejmirtes]

So I realize I don't want to have a long-term option for turning off DataProviderDataRule. I only want it to be conditional now in 2.x based on bleedingEdge.

As for the data provider return types, I can imagine there to be an option named something like reportMissingDataProviderReturnType that would default to false. You could set it to true to disable the ignore errors extension.

Feel free to send a PR.

[VincentLanglet]

Feel free to send a PR.

Like this #253 ?