Skip to content

IgnoreErrorExtension is a valid conditional-tag #4488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 27, 2025
Merged

IgnoreErrorExtension is a valid conditional-tag #4488

merged 1 commit into from
Oct 27, 2025

Conversation

@staabm
Copy link
Contributor

@staabm staabm commented Oct 27, 2025 •
edited
Loading

followup to #3783

hopefully fixes

24) PHPStan\Rules\PHPUnit\DataProviderDataRuleTest::testTrimmingArgs
_PHPStan_b24b79311\Nette\DI\InvalidConfigurationException: Unexpected item 'conditionalTags › PHPStan\Type\PHPUnit\DataProviderReturnTypeIgnoreExtension › phpstan.ignoreErrorExtension'.

phar:///Users/staabm/workspace/phpstan-phpunit/vendor/phpstan/phpstan/phpstan.phar/vendor/nette/di/src/DI/Compiler.php:219
phar:///Users/staabm/workspace/phpstan-phpunit/vendor/phpstan/phpstan/phpstan.phar/vendor/nette/di/src/DI/Compiler.php:178
phar:///Users/staabm/workspace/phpstan-phpunit/vendor/phpstan/phpstan/phpstan.phar/vendor/nette/di/src/DI/Compiler.php:158
phar:///Users/staabm/workspace/phpstan-phpunit/vendor/phpstan/phpstan/phpstan.phar/vendor/nette/di/src/DI/ContainerLoader.php:99
phar:///Users/staabm/workspace/phpstan-phpunit/vendor/phpstan/phpstan/phpstan.phar/vendor/nette/di/src/DI/ContainerLoader.php:65
phar:///Users/staabm/workspace/phpstan-phpunit/vendor/phpstan/phpstan/phpstan.phar/vendor/nette/di/src/DI/ContainerLoader.php:34
phar:///Users/staabm/workspace/phpstan-phpunit/vendor/phpstan/phpstan/phpstan.phar/src/DependencyInjection/Configurator.php:81
phar:///Users/staabm/workspace/phpstan-phpunit/vendor/phpstan/phpstan/phpstan.phar/vendor/nette/bootstrap/src/Bootstrap/Configurator.php:177
phar:///Users/staabm/workspace/phpstan-phpunit/vendor/phpstan/phpstan/phpstan.phar/src/DependencyInjection/Configurator.php:175
phar:///Users/staabm/workspace/phpstan-phpunit/vendor/phpstan/phpstan/phpstan.phar/src/DependencyInjection/ContainerFactory.php:107
phar:///Users/staabm/workspace/phpstan-phpunit/vendor/phpstan/phpstan/phpstan.phar/src/Testing/PHPStanTestCase.php:70
phar:///Users/staabm/workspace/phpstan-phpunit/vendor/phpstan/phpstan/phpstan.phar/src/Testing/PHPStanTestCase.php:105
phar:///Users/staabm/workspace/phpstan-phpunit/vendor/phpstan/phpstan/phpstan.phar/src/Testing/RuleTestCase.php:161
phar:///Users/staabm/workspace/phpstan-phpunit/vendor/phpstan/phpstan/phpstan.phar/src/Testing/RuleTestCase.php:95

in phpstan/phpstan-phpunit#246

@staabm staabm mentioned this pull request Oct 27, 2025
Merged
@ondrejmirtes ondrejmirtes merged commit 86e604c into phpstan:2.1.x Oct 27, 2025
539 of 556 checks passed
@ondrejmirtes
Copy link
Member

ondrejmirtes commented Oct 27, 2025

Thank you!

@staabm staabm deleted the cond branch October 27, 2025 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@staabm @ondrejmirtes